[PATCH v3 3/6] Documentation: DT: Document twl4030-madc-battery bindings
From: Dr. H. Nikolaus Schaller <hidden>
Date: 2015-03-16 21:38:23
Also in:
linux-devicetree, linux-omap, linux-pm, lkml
Am 16.03.2015 um 22:20 schrieb Belisko Marek [off-list ref]:
On Mon, Mar 16, 2015 at 10:05 PM, Pavel Machek [off-list ref] wrote:quoted
On Wed 2015-02-04 23:14:32, Marek Belisko wrote:quoted
Signed-off-by: Marek Belisko <redacted> --- .../bindings/power_supply/twl4030_madc_battery.txt | 43 ++++++++++++++++++++++ 1 file changed, 43 insertions(+) create mode 100644 Documentation/devicetree/bindings/power_supply/twl4030_madc_battery.txtdiff --git a/Documentation/devicetree/bindings/power_supply/twl4030_madc_battery.txt b/Documentation/devicetree/bindings/power_supply/twl4030_madc_battery.txt new file mode 100644 index 0000000..bb3580c --- /dev/null +++ b/Documentation/devicetree/bindings/power_supply/twl4030_madc_battery.txt@@ -0,0 +1,43 @@ +twl4030_madc_battery + +Required properties: + - compatible : "ti,twl4030-madc-battery" + - capacity-uah : battery capacity in uAhCould we make it capacity-uAh ?This name was suggested by Mark Rutland [1] and naming convention should be all lowercase. There exists already bindings without uppercase (e.g. ti,bb-uamp) so I would keep it consistent.quoted
quoted
+ - volt-to-capacity-charging-map : list of voltage(mV):level(%) values + for charging calibration (see example) + - volt-to-capacity-discharging-map : list of voltage(mV):level(%) values + for discharging calibration (see example)Would "mV-to-capacity..." be more accurate? Also, would it make senseAgain maybe mv but it can be added also later.quoted
to introduce coefficients for temperature and discharge rate?What do you mean? Nothing like that is used in current driver why do we need to add it?
Temperature calibration should have already been done in the underlaying twl4030 iio driver. Discharge rate is the real current flow reported in uA. Also reported by iio.
quoted
Thanks, Pavel -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html[1] - http://lists.openwall.net/linux-kernel/2014/10/09/104 BR, marek
BR, Nikolaus