Thread (41 messages) 41 messages, 15 authors, 2015-03-12

[alsa-devel] [PATCH 1/8] clk: add helper function clk_is_match()

From: p.zabel@pengutronix.de (Philipp Zabel)
Date: 2015-02-26 09:56:58
Also in: alsa-devel, dri-devel, linux-pwm, linux-serial

Am Donnerstag, den 26.02.2015, 09:02 +0000 schrieb Ben Dooks:
On Wed, Feb 25, 2015 at 09:27:57AM -0800, Mike Turquette wrote:
[...]
quoted
From: Michael Turquette <redacted>
Date: Wed, 25 Feb 2015 09:11:01 -0800
Subject: [PATCH] clk: introduce clk_is_match

Some drivers compare struct clk pointers as a means of knowing
if the two pointers reference the same clock hardware. This behavior is
dubious (drivers must not dereference struct clk), but did not cause any
regressions until the per-user struct clk patch was merged. Now the test
for matching clk's will always fail with per-user struct clk's.

clk_is_match is introduced to fix the regression and prevent drivers
from comparing the pointers manually.
small observaton, clk_is_same() is linguistically nicer.
How about clk_equal() ?

regards
Philipp
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help