Thread (41 messages) 41 messages, 15 authors, 2015-03-12
STALE4114d
Revisions (2)
  1. v1 [diff vs current]
  2. v1 current

[PATCH 0/8] Fix struct clk pointer comparing

From: Shawn Guo <hidden>
Date: 2015-02-26 01:21:39
Also in: alsa-devel, dri-devel, linux-pwm, linux-serial

On Wed, Feb 25, 2015 at 12:42:45PM -0800, Stephen Boyd wrote:
On 02/25/15 09:55, Mike Turquette wrote:
quoted
Quoting Russell King - ARM Linux (2015-02-25 07:03:49)
quoted
Case 1 applies in places like the Kirkwood I2S driver, and the iMX6
ethernet code, and it's these cases which need to be fixed.

Case 2 applies in the Armada DRM driver, and these cases need not be
"fixed".

To put it a different way: case 1 is when you're testing to see whether
two clocks refer to the same clock.  case 2 is when you're testing
whether the cached clk cookie is the same.
It looks like patches 2, 7 and 8 are correct in this series. I'll apply
them towards -rc2 if nobody objects.
For patch 8 can't we use the alternative patch that I came up with
before? I have a patch for sound/soc/fsl/fsl_esai.c and
drivers/pwm/pwm-atmel-hlcdc.c which I can send shortly.
This beats the idea of clk_is_match() helper.  I prefer to fix this
generic problem in a generic way, i.e. using clk_is_match(), which
should be much easier and safer during -rc cycle.

Shawn
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help