[PATCH v2 08/21] irqchip: crossbar: convert dra7 crossbar to stacked domains
From: Marc Zyngier <hidden>
Date: 2015-01-10 12:59:11
Also in:
linux-omap, linux-samsung-soc
On 2015-01-08 14:39, Nishanth Menon wrote:
On 17:42-20150107, Marc Zyngier wrote: [..]quoted
diff --git a/arch/arm/boot/dts/dra7-evm.dtsb/arch/arm/boot/dts/dra7-evm.dts index 10b725c..048cfeb 100644--- a/arch/arm/boot/dts/dra7-evm.dts +++ b/arch/arm/boot/dts/dra7-evm.dts@@ -423,7 +423,7 @@ status = "okay"; pinctrl-names = "default"; pinctrl-0 = <&uart1_pins>; - interrupts-extended = <&gic GIC_SPI 67 IRQ_TYPE_LEVEL_HIGH>, + interrupts-extended = <&crossbar_mpu GIC_SPI 67IRQ_TYPE_LEVEL_HIGH>, <&dra7_pmx_core 0x3e0>;^^ interrrupt-extended for uart1 here [..]quoted
diff --git a/arch/arm/boot/dts/dra7.dtsib/arch/arm/boot/dts/dra7.dtsi[...]quoted
@@ -344,7 +344,7 @@ uart1: serial at 4806a000 { compatible = "ti,omap4-uart"; reg = <0x4806a000 0x100>; - interrupts-extended = <&gic GIC_SPI 67 IRQ_TYPE_LEVEL_HIGH>; + interrupts = <GIC_SPI 67 IRQ_TYPE_LEVEL_HIGH>;^^ implies we will have both interrupts and interrupts-extended properties for uart1 in dra7-evm.dtb Documentation/devicetree/bindings/interrupt-controller/interrupts.txt does not make it clear as to what the priority will be when both properties are present.
Yup, good call. I don't think it matters (interrupts inherits the implicit irq-parent, but consistency is good.
quoted hunk ↗ jump to hunk
[...] Also, for 3.19-rc3, Missing the following causing x15 to fail boot.diff --git a/arch/arm/boot/dts/am57xx-beagle-x15.dtsb/arch/arm/boot/dts/am57xx-beagle-x15.dts index 49edbda68cd5..c2241c2e5d9d 100644--- a/arch/arm/boot/dts/am57xx-beagle-x15.dts +++ b/arch/arm/boot/dts/am57xx-beagle-x15.dts@@ -335,7 +335,6 @@ mcp_rtc: rtc at 6f { compatible = "microchip,mcp7941x"; reg = <0x6f>; - interrupt-parent = <&gic>; interrupts = <GIC_SPI 2 IRQ_TYPE_LEVEL_LOW>; /* IRQ_SYS_1N */ pinctrl-names = "default";@@ -358,7 +357,7 @@ &uart3 { status = "okay"; - interrupts-extended = <&gic GIC_SPI 69 IRQ_TYPE_LEVEL_HIGH>, + interrupts-extended = <&crossbar_mpu GIC_SPI 69IRQ_TYPE_LEVEL_HIGH>, <&dra7_pmx_core 0x248>; pinctrl-names = "default";
Ah, thanks for the patch, I've folded this in.
Thanks,
M.
--
Fast, cheap, reliable. Pick two.