Weird/Unneeded call to msleep in exynos_mipi_dsi_wr_data in exynos_mipi_dsi_common.c

From
Lucas Stach <l.stach@pengutronix.de>
Date
2014-12-18 13:40:01
Also in
linux-fbdev, linux-samsung-soc, lkml
Reply to
nick, 2014-12-18
Am Donnerstag, den 18.12.2014, 08:35 -0500 schrieb nick:
Krzysztof,
If we look at the code for this function, it already is handling the data correctly. In addition  the locks 
seem to be better protection then msleep. Further more is no reason for this delay as we are neither resetting 
the hardware or waiting for the hardware here so why is it needed? I don't have Exynos based hardware lying
around through to test it.
If you can't test it, don't touch it. It's that simple.

Regards,
Lucas
-- 
Pengutronix e.K.             | Lucas Stach                 |
Industrial Linux Solutions   | http://www.pengutronix.de/  |
Thread (7 messages) 7 messages, 4 authors, last reply 2014-12-18
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help