Re: Weird/Unneeded call to msleep in exynos_mipi_dsi_wr_data in exynos_mipi_dsi_common.c

Started by Lucas Stach on Dec 18, 2014

open the first message on its own page

Message details and related content
Am Donnerstag, den 18.12.2014, 08:35 -0500 schrieb nick:
Krzysztof,
If we look at the code for this function, it already is handling the data correctly. In addition  the locks 
seem to be better protection then msleep. Further more is no reason for this delay as we are neither resetting 
the hardware or waiting for the hardware here so why is it needed? I don't have Exynos based hardware lying
around through to test it.
If you can't test it, don't touch it. It's that simple.

Regards,
Lucas
-- 
Pengutronix e.K.             | Lucas Stach                 |
Industrial Linux Solutions   | http://www.pengutronix.de/  |
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help