On Mon, Oct 27, 2014 at 06:05:35PM +0100, Heiko St?bner wrote:

Am Montag, 27. Oktober 2014, 11:47:41 schrieb Felipe Balbi:

quoted

On Mon, Oct 27, 2014 at 05:41:03PM +0100, Johan Hovold wrote:

quoted

On Mon, Oct 27, 2014 at 11:38:40AM -0500, Felipe Balbi wrote:

quoted

On Mon, Oct 27, 2014 at 04:26:46PM +0000, Romain Perier wrote:

quoted

As discussed on the mailing list, it makes more sense to rename this
property to "system-power-controller". Problem being that the word
"source" usually tends to be used for inputs and that is out of
control of the OS. The poweroff capability is an output which simply
turns the system-power off. Also, this property might be used by
drivers which power-off the system and power back on subsequent RTC
alarms. This seems to suggest to remove "poweroff" from the property
name and to choose "system-power-controller" as the more generic
name. This patchs adds the required renaming changes and defines an
helper function which is compatible with both properties, the old one
prefixed by a vendor name and the new one without any prefix.

I think you still need to support poweroff-source since it has been
released on a stable kernel. Perhaps add a warning message telling users
it's deprecated and asking them to switch over to
system-power-controller ? Still, simply removing it isn't very nice.

No, Romain sent a patch that replaced "<vendor>,system-power-controller"
with "poweroff-source". It's now in Mark's tree (for v3.19), and this
series "reverts" to the old name minus the vendor-prefix.

oh, so poweroff-source isn't in Linus' tree yet ? (/me goes grep)

Then it should be fine. My bad.

Many of the other comments are still valid because even though
poweroff-source isn't in mainline yet, this series still creates
bisection points which are broken. The best solution would be to drop
all those patches from Mark's tree. Read, not revert, drop.

There have never been any users of the poweroff-source. The act8846 in the 
radxarock would have been the first, but I held off with the dts patch as the 
naming issue came up at the same time.

So I guess if Romain keeps the renaming together there shouldn't be any other 
bad bisection points?

Not build breaks, but there will always be the commit below:

commit a88f5c6deb2a44f694b01aac48231ec97059b26a
Author: Romain Perier [off-list ref]
Date:   Tue Oct 14 06:31:12 2014 +0000

    dt-bindings: Document the standard property "poweroff-source"
    
    Signed-off-by: Romain Perier [off-list ref]
    Signed-off-by: Mark Brown [off-list ref]

diff --git a/Documentation/devicetree/bindings/power/poweroff.txt b/Documentation/devicetree/bindings/power/poweroff.txt
new file mode 100644
index 0000000..845868b
--- /dev/null
+++ b/Documentation/devicetree/bindings/power/poweroff.txt

@@ -0,0 +1,18 @@
+* Generic Poweroff capability
+
+Power-management integrated circuits or miscellaneous harware components are
+sometimes able to control the system power. The device driver associated to these
+components might needs to define poweroff capability, which tells to the kernel
+how to switch off the system. The corresponding driver must have the standard
+property "poweroff-source" in its device node. This property marks the device as
+able to shutdown the system. In order to test if this property is found
+programmatically, use the helper function "of_system_has_poweroff_source" from
+of.h .
+
+Example:
+
+act8846: act8846 at 5 {
+	 compatible = "active-semi,act8846";
+	 status = "okay";
+	 poweroff-source;
+}

Even if for a small time frame, there will always be a commit where we
called "poweroff-source" a standard binding and, as such, as should
support it.

-- 
balbi
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20141027/b90740a2/attachment.sig>