Thread (36 messages) 36 messages, 7 authors, 2014-10-28

[PATCH v1 01/10] of: Rename "poweroff-source" property to "system-power-controller"

From: johan@kernel.org (Johan Hovold)
Date: 2014-10-27 16:44:17
Also in: linux-devicetree, linux-pm, linux-tegra, lkml

On Mon, Oct 27, 2014 at 11:38:40AM -0500, Felipe Balbi wrote:
On Mon, Oct 27, 2014 at 04:26:46PM +0000, Romain Perier wrote:
quoted
As discussed on the mailing list, it makes more sense to rename this property
to "system-power-controller". Problem being that the word "source" usually tends
to be used for inputs and that is out of control of the OS. The poweroff
capability is an output which simply turns the system-power off. Also, this
property might be used by drivers which power-off the system and power back on
subsequent RTC alarms. This seems to suggest to remove "poweroff" from the
property name and to choose "system-power-controller" as the more generic name.
This patchs adds the required renaming changes and defines an helper function
which is compatible with both properties, the old one prefixed by a vendor name
and the new one without any prefix.
I think you still need to support poweroff-source since it has been
released on a stable kernel. Perhaps add a warning message telling users
it's deprecated and asking them to switch over to
system-power-controller ? Still, simply removing it isn't very nice.
No, Romain sent a patch that replaced "<vendor>,system-power-controller"
with "poweroff-source". It's now in Mark's tree (for v3.19), and this
series "reverts" to the old name minus the vendor-prefix.

Johan
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help