Thread (13 messages) 13 messages, 7 authors, 2014-11-02

[PATCH v2 3/3] ARM: dts: qcom: Add SDHC nodes for APQ8084 platform

From: Bjorn Andersson <hidden>
Date: 2014-10-10 17:14:43
Also in: linux-arm-msm, linux-devicetree, lkml

On Tue, Sep 2, 2014 at 8:40 AM, Georgi Djakov [off-list ref] wrote:
Enable support for the two SD host controllers on the APQ8084 platform
by adding the required nodes to the DT files.
On the IFC6540 board, the first controller is connected to the onboard
eMMC and the second is connected to a micro-SD card slot.

Signed-off-by: Georgi Djakov <redacted>
Hi Georgi,

This looks sane, but...
quoted hunk ↗ jump to hunk
---
 arch/arm/boot/dts/qcom-apq8084-ifc6540.dts |   11 +++++++++++
 arch/arm/boot/dts/qcom-apq8084.dtsi        |   23 +++++++++++++++++++++++
 2 files changed, 34 insertions(+)
diff --git a/arch/arm/boot/dts/qcom-apq8084-ifc6540.dts b/arch/arm/boot/dts/qcom-apq8084-ifc6540.dts
index e41cb8a..c9ff108 100644
--- a/arch/arm/boot/dts/qcom-apq8084-ifc6540.dts
+++ b/arch/arm/boot/dts/qcom-apq8084-ifc6540.dts
[..]
+               sdhci at f98a4900 {
+                       cd-gpios = <&tlmm 122 GPIO_ACTIVE_LOW>;
+                       bus-width = <4>;
...why do you add this node and leave it disabled in the dts?
+               };
        };
 };
Regards,
Bjorn
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help