Hi Arnd,

On 2 September 2014 21:16, Arnd Bergmann [off-list ref] wrote:

On Tuesday 02 September 2014 20:52:00 Naveen Krishna Chatradhi wrote:

quoted

Make the config symbols SERIAL_SAMSUNG_UARTS_4 and
SERIAL_SAMSUNG_UARTS depend on SERIAL_SAMSUNG rather than
PLAT_SAMSUNG.

Please always describe why you are doing a change. This patch
seems really pointless.

The SERIAL_SAMSUNG_UARTS_4 and SERIAL_SAMSUNG_UARTS config options are
meaningful only if SERIAL_SAMSUNG is enabled. Hence the dependency
rules were changed. I will repost this patch with better description.

quoted

 config SERIAL_SAMSUNG_UARTS_4
        bool
-       depends on PLAT_SAMSUNG
+       depends on SERIAL_SAMSUNG
        default y if !(CPU_S3C2410 || CPU_S3C2412 || CPU_S3C2440 || CPU_S3C2442)
        help
          Internal node for the common case of 4 Samsung compatible UARTs

 config SERIAL_SAMSUNG_UARTS
        int
-       depends on PLAT_SAMSUNG
+       depends on SERIAL_SAMSUNG
        default 4 if SERIAL_SAMSUNG_UARTS_4 || CPU_S3C2416
        default 3
        help

Have you checked that it still builds on all samsung platforms when
SERIAL_SAMSUNG is disabled? We have had build errors in this area
in the past.

Yes, it builds for other Samsung platforms.

        Arnd

Thanks.

-- 
Shine bright,
(: Nav :)