[PATCH] tty/serial: fix config dependencies for samsung serial
From: arnd@arndb.de (Arnd Bergmann)
Date: 2014-09-02 15:46:58
Also in:
linux-samsung-soc, linux-serial, lkml
From: arnd@arndb.de (Arnd Bergmann)
Date: 2014-09-02 15:46:58
Also in:
linux-samsung-soc, linux-serial, lkml
On Tuesday 02 September 2014 20:52:00 Naveen Krishna Chatradhi wrote:
Make the config symbols SERIAL_SAMSUNG_UARTS_4 and SERIAL_SAMSUNG_UARTS depend on SERIAL_SAMSUNG rather than PLAT_SAMSUNG.
Please always describe why you are doing a change. This patch seems really pointless.
config SERIAL_SAMSUNG_UARTS_4
bool
- depends on PLAT_SAMSUNG
+ depends on SERIAL_SAMSUNG
default y if !(CPU_S3C2410 || CPU_S3C2412 || CPU_S3C2440 || CPU_S3C2442)
help
Internal node for the common case of 4 Samsung compatible UARTs
config SERIAL_SAMSUNG_UARTS
int
- depends on PLAT_SAMSUNG
+ depends on SERIAL_SAMSUNG
default 4 if SERIAL_SAMSUNG_UARTS_4 || CPU_S3C2416
default 3
helpHave you checked that it still builds on all samsung platforms when SERIAL_SAMSUNG is disabled? We have had build errors in this area in the past. Arnd