[PATCH 5/5] phy: exynos5-usbdrd: Adding Kconfig dependency for Exynos7
From: Vivek Gautam <hidden>
Date: 2014-09-03 04:02:17
Also in:
linux-devicetree, linux-omap, linux-samsung-soc, lkml
From: Vivek Gautam <hidden>
Date: 2014-09-03 04:02:17
Also in:
linux-devicetree, linux-omap, linux-samsung-soc, lkml
On Tue, Sep 2, 2014 at 8:07 PM, Felipe Balbi [off-list ref] wrote:
On Mon, Sep 01, 2014 at 01:30:21PM +0530, Vivek Gautam wrote:quoted
On Thu, Aug 28, 2014 at 8:36 PM, Daniele Forsi [off-list ref] wrote:quoted
2014-08-28 10:02 GMT+02:00 Vivek Gautam:quoted
This USB 3.0 PHY controller is also present on Exynos7 platform, so adding the dependency on ARCH_EXYNOS7 for this driver.quoted
+++ b/drivers/phy/Kconfig@@ -186,7 +186,7 @@ config PHY_EXYNOS5250_USB2 config PHY_EXYNOS5_USBDRD tristate "Exynos5 SoC series USB DRD PHY driver" - depends on ARCH_EXYNOS5 && OF + depends on (ARCH_EXYNOS5 || ARCH_EXYNOS7) && OFshouldn't that prompt and its help text be updated to mention also Exynos7?Right, even that has to be updated accordingly. Will update the same in next version of the patch. Thanks for pointing this.I would rather change that to ARCH_EXYNOS, unless Kishon doesn't like that idea. The thing is that this will likely need to be patches for exynos8, 9, 10, 11...
Yes, after we have the 2nd version of Exynos7 support patches, it makes more sense to keep dependency on ARCH_EXYNOS. -- Best Regards Vivek Gautam Samsung R&D Institute, Bangalore India