Hi Felipe,


On Fri, Aug 29, 2014 at 12:46 AM, Felipe Balbi [off-list ref] wrote:

hi,

On Thu, Aug 28, 2014 at 01:31:58PM +0530, Vivek Gautam wrote:

quoted

@@ -457,11 +458,19 @@ static int exynos5_usbdrd_phy_power_on(struct phy *phy)
      clk_prepare_enable(phy_drd->ref_clk);

      /* Enable VBUS supply */
+     if (phy_drd->vbus_boost) {
+             ret = regulator_enable(phy_drd->vbus_boost);
+             if (ret) {
+                     dev_err(phy_drd->dev,
+                             "Failed to enable VBUS boost supply\n");
+                     goto fail_vbus;
+             }
+     }

really this is nitpicking, but can you add a blank line here just make
my inner child happy ? :-)

Sure will add an extra line here and similar instances of this change.

quoted

@@ -470,6 +479,9 @@ static int exynos5_usbdrd_phy_power_on(struct phy *phy)

      return 0;

+fail_vbus_boost:
+     if (phy_drd->vbus_boost)
+             regulator_disable(phy_drd->vbus_boost);

same here

--
balbi

-- 
Best Regards
Vivek Gautam
Samsung R&D Institute, Bangalore
India