On 07/31/2014 05:24 PM, Sergei Shtylyov wrote:

Hello.

On 07/31/2014 02:18 PM, Peter Ujfalusi wrote:

quoted

The board uses aic3106 for audio.

quoted

Signed-off-by: Peter Ujfalusi <redacted>
---
  arch/arm/boot/dts/da850-evm.dts | 14 ++++++++++++++
  1 file changed, 14 insertions(+)

quoted

diff --git a/arch/arm/boot/dts/da850-evm.dts b/arch/arm/boot/dts/da850-evm.dts
index 09118c72e83f..b9ef2be0b145 100644
--- a/arch/arm/boot/dts/da850-evm.dts
+++ b/arch/arm/boot/dts/da850-evm.dts

@@ -51,6 +51,20 @@
              tps: tps at 48 {
                  reg = <0x48>;
              };
+            tlv320aic3106: tlv320aic3106 at 1b {

   The "reg" property is <0x18>, why the unit-address part of a name is
different?

True, I have lifted the codec part from other dts file and overlooked the
unit-address.
I will resend the series with this fixed.

Also, the ePAPR standard [1] says:

The name of a node should be somewhat generic, reflecting the function of the
device and not its precise programming model.

True. This is why the node for the audio support is named as 'sound'. For the
components, like in this case I do not see issue to call the audio codec with
it's name.

quoted

+                #sound-dai-cells = <0>;
+                compatible = "ti,tlv320aic3106";
+                reg = <0x18>;
+                status = "okay";
+
+                /* Regulators */
+                IOVDD-supply = <&vdcdc2_reg>;
+                /* Derived from VBAT: Baseboard 3.3V / 1.8V */
+                AVDD-supply = <&vbat>;
+                DRVDD-supply = <&vbat>;
+                DVDD-supply = <&vbat>;
+            };
+

[1] http://www.power.org/resources/downloads/Power_ePAPR_APPROVED_v1.0.pdf

BTW: there's a newer version available:
https://www.power.org/wp-content/uploads/2012/06/Power_ePAPR_APPROVED_v1.1.pdf

WBR, Sergei

-- 
P?ter