Hi Tomasz,

On Sat, Jul 19, 2014 at 6:48 PM, Tomasz Figa [off-list ref] wrote:

Hi Thomas,

Please see my comments inline.

On 14.07.2014 15:38, Thomas Abraham wrote:

quoted

From: Thomas Abraham <redacted>

For Exynos 4210/5250/5420 based platforms, add CPU nodes, operating points and
cpu clock data for migrating from Exynos specific cpufreq driver to using
generic cpufreq drivers.

[snip]

quoted

diff --git a/arch/arm/boot/dts/exynos4210.dtsi b/arch/arm/boot/dts/exynos4210.dtsi
index ee3001f..c3a73bf 100644
--- a/arch/arm/boot/dts/exynos4210.dtsi
+++ b/arch/arm/boot/dts/exynos4210.dtsi

@@ -31,6 +31,33 @@
              pinctrl2 = &pinctrl_2;
      };

+     cpus {
+             #address-cells = <1>;
+             #size-cells = <0>;
+             cpu at 0 {

nit: Missing blank line after last property.

The cluster ID field of MPIDR on Exynos4210 is 0x9 not zero, which means
that this should be cpu at 900.

quoted

+                     device_type = "cpu";
+                     compatible = "arm,cortex-a9";
+                     reg = <0>;

                        reg = <0x900>;

quoted

+                     clocks = <&clock CLK_ARM_CLK>;
+                     clock-names = "cpu";
+
+                     operating-points = <
+                             1200000 1250000
+                             1000000 1150000
+                             800000  1075000
+                             500000  975000
+                             400000  975000
+                             200000  950000
+                     >;
+             };
+
+             cpu at 1 {

                cpu at 901

quoted

+                     device_type = "cpu";
+                     compatible = "arm,cortex-a9";
+                     reg = <1>;

                        reg = <0x901>;

quoted

+             };

In general this wouldn't have even booted, because there were several
places where code relied on CPUs being 0, 1, 2... However I have sent
necessary fixes and they should hit linux-next in few days.

quoted

+     };
+
      sysram at 02020000 {
              compatible = "mmio-sram";
              reg = <0x02020000 0x20000>;

[snip]

quoted

diff --git a/arch/arm/boot/dts/exynos5250.dtsi b/arch/arm/boot/dts/exynos5250.dtsi
index 834fb5a..66b0f98 100644
--- a/arch/arm/boot/dts/exynos5250.dtsi
+++ b/arch/arm/boot/dts/exynos5250.dtsi

@@ -63,6 +63,29 @@
                      compatible = "arm,cortex-a15";
                      reg = <0>;
                      clock-frequency = <1700000000>;
+
+                     clocks = <&clock CLK_ARM_CLK>;
+                     clock-names = "cpu";
+
+                     operating-points = <
+                             1700000 1300000
+                             1600000 1250000
+                             1500000 1225000
+                             1400000 1200000
+                             1300000 1150000
+                             1200000 1125000
+                             1100000 1100000
+                             1000000 1075000
+                              900000 1050000
+                              800000 1025000
+                              700000 1012500
+                              600000 1000000
+                              500000  975000
+                              400000  950000
+                              300000  937500
+                              200000  925000
+                     >;
+                     clock-latency = <200000>;

I don't see this property specified for Exynos4210. Have you missed it
there?

Okay, I have specified this for Exynos4210 as well.

Thanks,
Thomas.

Best regards,
Tomasz

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel at lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel