Thread (40 messages) 40 messages, 5 authors, 2014-07-21

[PATCHv2 12/17] cpuidle: mvebu: make the cpuidle driver capable of handling multiple SoCs

From: arnd@arndb.de (Arnd Bergmann)
Date: 2014-07-21 12:51:38
Also in: linux-pm

On Monday 21 July 2014 14:38:13 Thomas Petazzoni wrote:
Dear Daniel Lezcano,

On Mon, 21 Jul 2014 14:34:23 +0200, Daniel Lezcano wrote:
quoted
So there are three solutions:

1. Pass the flag through the platform data, I am not really in favor of 
that as mentioned above
That's what is already implemented.
It's certainly better than checking a global compatible string in
driver code, IMHO.

Instead of a global header file, I would have put the structure
definition under linux/platform-data, as we do for most other
legacy drivers.
quoted
2. Use the compatible string like the cpuidle-big-little.c driver, but 
Arnd is not in favor of that

3. Register 3 platform drivers, in cpuidle-mvebu-v7.c, and let the 
registering of the cpuidle's platform device to enable the right one
I'm fine with doing (3). Daniel, Arnd, let me know if that's ok for
you, and I'll respin the patch series accordingly.
If I understood Daniel correctly, this is temporary anyway until
we have a proper binding, right?

If so, I don't really mind either approach.

	Arnd
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help