[PATCH 03/16] ARM: mvebu: Add function to export the physical address of the boot register
From: Thomas Petazzoni <hidden>
Date: 2014-07-01 11:46:51
Also in:
linux-pm
From: Thomas Petazzoni <hidden>
Date: 2014-07-01 11:46:51
Also in:
linux-pm
Dear Gregory CLEMENT, On Fri, 27 Jun 2014 15:22:44 +0200, Gregory CLEMENT wrote:
static void __iomem *system_controller_base; +static u32 system_controller_phys_base; struct mvebu_system_controller { u32 rstoutn_mask_offset;@@ -109,6 +110,13 @@ void mvebu_system_controller_set_cpu_boot_addr(void *boot_addr) writel(virt_to_phys(boot_addr), system_controller_base + mvebu_sc->resume_boot_addr); } + +u32 mvebu_system_controller_get_phys_addr(void) +{ + BUG_ON(system_controller_phys_base == NULL);
This rightfully generates a fairly strong warning at compile time: you're comparing an u32 to NULL. It should be == 0 here. Best regards, Thomas -- Thomas Petazzoni, CTO, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com