[PATCH 00/13] uio_pruss: add support for devicetree and am33xx
From: Hans J. Koch <hidden>
Date: 2014-07-09 10:16:00
Also in:
linux-devicetree, linux-omap
On Mon, Jul 07, 2014 at 05:50:09PM +0000, Paul Walmsley wrote:
On Mon, 7 Jul 2014, Andre Heider wrote:quoted
On Sun, Jun 29, 2014 at 06:21:34PM +0200, Andre Heider wrote:quoted
this series adds PRUv2 support to uio_pruss through devicetree, makes the device usable on am33xx and enables it on beaglebone black. Inspired by old patches from Matt Porter found in a downstream tree. To archieve that this series: * adds a flag to omap_hwmod.c to get PRUSS out of hardreset (patch 5 and 6)...quoted
quoted
* is the hardreset thing I did there the right thing to do? I think the proper way would be a reset controller (which apparently doesn't yet exist for this SoC?) and let the driver deassert/assert on probe/remove? * the platform device path has a clk_enable() / clk_put() calls. Are those now redundant with the introduced pm_runtime_enable() pm_runtime_disable() calls?Probably you only need pm_runtime_{get,put}_*() calls, unless you're changing clock parents or rates in your driver code.quoted
@OMAP guys: any comments? The series depends on patch 5 and 6; both touch common hwmod code.I'd suggest splitting the series into three independent pieces if possible: 1. UIO code, for the UIO maintainer(s) 2. DT pieces for Tony 3. hwmod pieces for me That way they can be cleanly merged by the respective maintainers.
I second that. At first sight, the UIO parts look OK to me, but please make it a new patch series. Thanks, Hans