Thread (24 messages) flat view 24 messages, 5 authors, 2014-08-01

[PATCH 02/13] uio: uio_pruss: use devm_kzalloc()

From: Andre Heider <hidden>
Date: 2014-06-30 19:42:40
Also in: linux-devicetree, linux-omap

On Mon, Jun 30, 2014 at 10:38:09AM +0100, Mark Rutland wrote:
On Sun, Jun 29, 2014 at 05:21:36PM +0100, Andre Heider wrote:
quoted
--- a/drivers/uio/uio_pruss.c
+++ b/drivers/uio/uio_pruss.c
@@ -109,9 +109,7 @@ static void pruss_cleanup(struct device *dev, struct uio_pruss_dev *gdev)
 		gen_pool_free(gdev->sram_pool,
 			      gdev->sram_vaddr,
 			      sram_pool_sz);
-	kfree(gdev->info);
 	clk_put(gdev->pruss_clk);
-	kfree(gdev);
 }
 
 static int pruss_probe(struct platform_device *pdev)
@@ -123,24 +121,19 @@ static int pruss_probe(struct platform_device *pdev)
 	int ret = -ENODEV, cnt = 0, len;
 	struct uio_pruss_pdata *pdata = dev_get_platdata(dev);
 
-	gdev = kzalloc(sizeof(struct uio_pruss_dev), GFP_KERNEL);
+	gdev = devm_kzalloc(dev, sizeof(struct uio_pruss_dev), GFP_KERNEL);
If this is changing anyway, how about:

	gdev = devm_kzalloc(dev, sizeof(*gdev), GFP_KERNEL);
Sounds good, will do just that.

Thanks for having at look at the series, Mark!

Regards,
Andre
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help