Am 31.07.2014 21:19, schrieb Tomasz Figa:

Andreas,

Please see my comments inline.

On 31.07.2014 18:08, Andreas F?rber wrote:

quoted

Use the new style of referencing inherited nodes and use symbolic names.

Suggested-by: Doug Anderson <dianders@chromium.org>
Signed-off-by: Andreas F?rber <afaerber@suse.de>

[snip]

quoted

-
 	usb at 12110000 {
-		samsung,vbus-gpio = <&gpx1 1 0>;
+		samsung,vbus-gpio = <&gpx1 1 GPIO_ACTIVE_HIGH>;
 	};

This is a higher level node being overridden, so it should be specified
using references too.

quoted

 
 	fixed-rate-clocks {

@@ -287,7 +206,7 @@
 	};
 
 	hdmi {

Ditto.

Same problem as with spring: We need the labels first!

Andreas

-- 
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N?rnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imend?rffer; HRB 16746 AG N?rnberg