Thread (41 messages) 41 messages, 8 authors, 2014-07-21

[PATCHv6 0/4] iio: adc: exynos_adc: Support Exynos3250 ADC and code clean

From: Naveen Krishna Ch <hidden>
Date: 2014-07-18 10:17:17
Also in: linux-devicetree, linux-iio, linux-samsung-soc, lkml

Hello All,

On 18 July 2014 15:43, Naveen Krishna Ch [off-list ref] wrote:
Hello Arnd,

On 18 July 2014 15:08, Arnd Bergmann [off-list ref] wrote:
quoted
On Friday 18 July 2014 14:59:42 Chanwoo Choi wrote:
quoted
This patchset support Exynos3250 ADC (Analog Digital Converter) because
Exynos3250 has additional special clock for ADC IP.
by coincidence, I have just looked at the same driver in order to
add support for s3c24xx and s3c64xx, so we can remove the plat-samsung
adc framework they still use.  Those changes would naturally conflict
with yours, but I think it makes sense for your patches to come first.

I'll comment a bit more on the individual patches. I didn't have
interest in them earlier, so I didn't comment so far.

Another aspect that came up is the touchscreen support. Right now,
there is drivers/input/touchscreen/s3c2410_ts.c which is intimately
tied to arch/arm/plat-samsung/adc.c. The best way forward (as discussed
on IRC as few days ago) seems to be to integrate support for that into
the exynos_adc driver. Can you comment on which parts actually support
touchscreen? Did touchscreen support get dropped in the exynos hardware,
or is the driver just missing at the moment?
SoCs from Samsung before Exynos4 had and ADC based Touch screen
and the driver under arch/arm/plat-samsung/adc.c and
drivers/input/touchscreen/s3c2410_ts.c used to work together.

Infact, the interrupt routine and priorities in plat-samsung/adc.c
driver as written keeping the Touchscreen in mind.

After Exynos4, ADC IP remained. But, the touch screen was removed in hardware.
At least on Exynos4210> i'm not sure about the other Exynos4 series.
I will try to verify the user manuals.
As per suggestion from Doug Anderson, I've implemented IIO based ADC
driver started to support from exynos5250.
quoted
        Arnd
--
To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in
the body of a message to majordomo at vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html


--
Shine bright,
(: Nav :)


-- 
Shine bright,
(: Nav :)
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help