Thread (76 messages) 76 messages, 5 authors, 2014-10-23

[PATCH v3 1/2] cpufreq: Don't destroy/realloc policy/sysfs on hotplug/suspend

From: viresh.kumar@linaro.org (Viresh Kumar)
Date: 2014-07-17 05:35:17
Also in: linux-arm-msm, linux-pm, lkml

On 17 July 2014 01:26, Saravana Kannan [off-list ref] wrote:
On 07/16/2014 04:16 AM, Srivatsa S. Bhat wrote:
quoted
That is, we wanted
to do the kobject cleanup after releasing the hotplug lock, and POST_DEAD
stage was well-suited for that.
I think, this has changed in Saravana's patch, we do it in the PREPARE stage
now.
quoted
Commit 1aee40ac9c8 (cpufreq: Invoke __cpufreq_remove_dev_finish() after
releasing cpu_hotplug.lock) explains this in detail. Saravana, please take
a
look at that reasoning and ensure that your patch doesn't re-introduce
those
deadlock possibilities!

But all of that was needed _because_ we were creating and destroying
policies and kobjs all the time. We don't do that anymore. So, I don't think
any of that applies. We only destroy when the cpufreq driver is
unregistered. That's kinda of the point of this patchset.

Thoughts?
See above.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help