Thread (49 messages) 49 messages, 6 authors, 2014-07-01

[PATCH 22/24] ARM64:ILP32: Use a seperate syscall table as a few syscalls need to be using the compat syscalls.

From: arnd@arndb.de (Arnd Bergmann)
Date: 2014-07-01 17:04:50
Also in: lkml

On Tuesday 01 July 2014 17:50:41 Catalin Marinas wrote:
On Tue, Jul 01, 2014 at 05:38:12PM +0100, Arnd Bergmann wrote:
quoted
On Tuesday 01 July 2014 15:30:51 Pinski, Andrew wrote:
quoted
quoted
On Jul 1, 2014, at 8:07 AM, "Catalin Marinas" [off-list ref] wrote:
quoted
On Sat, May 24, 2014 at 12:02:17AM -0700, Andrew Pinski wrote:
diff --git a/arch/arm64/kernel/entry.S b/arch/arm64/kernel/entry.S
index 1e1ebfc..8241ffe 100644
--- a/arch/arm64/kernel/entry.S
+++ b/arch/arm64/kernel/entry.S
@@ -620,9 +620,14 @@ ENDPROC(ret_from_fork)
 */
   .align    6
el0_svc:
-    adrp    stbl, sys_call_table        // load syscall table pointer
   uxtw    scno, w8            // syscall number in w8
   mov    sc_nr, #__NR_syscalls
+#ifdef CONFIG_ARM64_ILP32
+    get_thread_info tsk
+    ldr    x16, [tsk, #TI_FLAGS]
+    tbnz    x16, #TIF_32BIT_AARCH64, el0_ilp32_svc // We are using ILP32
+#endif
+    adrp    stbl, sys_call_table        // load syscall table pointer
This adds a slight penalty on the AArch64 SVC entry path. I can't tell
whether that's visible or not but I think the x86 guys decided to set an
extra bit to the syscall number to distinguish it from native calls.
IIRC the intention on x86 was that you should always be able to call
any of the three syscall ABIs (x86-32, x86-64, x32) from any process
by passing the right number, for flexibility.
I don't see how this is useful though. Do you happen to have more
information?
It's been a decade since this code was merged, so my memory isn't very
good here. I believe one of the main reasons was being able to run
emulation layers in user space that make use of the kernel helpers.

Another use case might be an application that wants to use the native
ioctl interface for a driver that does not have a (efficient) compat
ioctl handler.

	Arnd
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help