On Jun 16, 2014, at 10:08 AM, "Catalin Marinas" [off-list ref] wrote:

Andrew,

quoted

On Sat, May 24, 2014 at 12:01:55AM -0700, Andrew Pinski wrote:
New version of the patches with documentation, signal changes are
simplified, using less compat syscalls and splitting up the patches so
it is easier to review.  I have tested LTP on both LP64 and ILP32.
There is a few LTP failures but they are due to LTP being incorrect
(sigaction structure in glibc is not the one which is used by the
kernel)

Do you have more details about what's wrong here and where the fix
should go? LTP? glibc? Kernel?

LTP assumes some sigaction structure is the same between userland and kernel.
Glibc has the correct idea of what the kernel structure will be when passing to the kernel already. The fix should be done in LTP. There is already code in LTP for x86 for a similar issue which we should be able to advantage of. 

I'll give you more specific comments on the code in the next couple of
days. But for cosmetics, please wrap the lines around 72 (or whatever)
characters both in emails, commit logs and Documentation/* files (and
you can drop the "Thanks" part in every commit log ;)).

Will do this with the rest of the review. 

quoted

Andrew Pinski (24):
 ARM64: Force LP64 to compile the kernel.
 ARM64: Rename COMPAT to AARCH32_EL0 in Kconfig.
 ARM64: Change some CONFIG_COMPAT over to use CONFIG_AARCH32_EL0
   instead.
 ARM64:ILP32: Set kernel_long to long long so we can reuse most of the
   same syscalls as LP64.
 ARM64:UAPI: Set the correct __BITS_PER_LONG for ILP32.
 Allow for some signal structures to be the same between a 32bit ABI
   and the 64bit ABI.
 ARM64:ILP32: Use the same size and layout of the signal structures
   for ILP32 as for LP64.
 Allow a 32bit ABI to use the naming of the 64bit ABI syscalls to
   avoid confusion of not splitting the registers.
 ARM64:ILP32: Use the same syscall names as LP64.
 ARM64: Introduce is_a32_task and is_a32_thread. Use them in the
   correct locations.
 ARM64: Add ARM64_ILP32 to Kconfig.

Does this patch need to be in the middle of the series? It should come
after the ILP32 support is complete.

Ok, I will move it. I had added in the middle to test the newly added code. 

Thanks,
Andrew

Thanks.

-- 
Catalin