Thread (6 messages) flat view 6 messages, 4 authors, 2014-07-02

[PATCH] spi: qup: Add DMA capabilities

From: Andy Gross <hidden>
Date: 2014-06-27 15:54:27
Also in: linux-arm-msm, linux-spi, lkml

On Fri, Jun 27, 2014 at 11:50:57AM +0100, Mark Brown wrote:
On Thu, Jun 26, 2014 at 04:06:21PM -0500, Andy Gross wrote:
quoted
+	if (xfer->rx_buf) {
+		rx_dma = dma_map_single(controller->dev, xfer->rx_buf,
+			xfer->len, DMA_FROM_DEVICE);
It would be better to use the core DMA mapping code rather than open
coding.  This code won't work for vmalloc()ed addresses, or physically
non-contiguous addresses unless there's an IOMMU fixing things up.
Ah, ok.  So I just need a to setup the scatter gather page list and then do a
dma_map_sg.  I'll resend once I have this in place.


-- 
sent by an employee of the Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
hosted by The Linux Foundation
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help