Thread (6 messages) flat view 6 messages, 4 authors, 2014-07-02

[PATCH] spi: qup: Add DMA capabilities

From: broonie@kernel.org (Mark Brown)
Date: 2014-06-27 10:51:50
Also in: linux-arm-msm, linux-spi, lkml

On Thu, Jun 26, 2014 at 04:06:21PM -0500, Andy Gross wrote:
+	if (xfer->rx_buf) {
+		rx_dma = dma_map_single(controller->dev, xfer->rx_buf,
+			xfer->len, DMA_FROM_DEVICE);
It would be better to use the core DMA mapping code rather than open
coding.  This code won't work for vmalloc()ed addresses, or physically
non-contiguous addresses unless there's an IOMMU fixing things up.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20140627/0c812691/attachment.sig>
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help