[PATCH v7 4/9] seccomp: move no_new_privs into seccomp

From
Oleg Nesterov <oleg@redhat.com>
Date
2014-06-24 19:32:49
Also in
linux-api, linux-arch, linux-mips, lkml
Reply to
Andy Lutomirski, 2014-06-24
On 06/24, Andy Lutomirski wrote:
On Tue, Jun 24, 2014 at 12:18 PM, Oleg Nesterov [off-list ref] wrote:
quoted
quoted

-struct seccomp { };
+struct seccomp {
+     unsigned long flags;
+};
A bit messy ;)

I am wondering if we can simply do

        static inline bool current_no_new_privs(void)
        {
                if (current->no_new_privs)
                        return true;

        #ifdef CONFIG_SECCOMP
                if (test_thread_flag(TIF_SECCOMP))
                        return true;
        #endif
Nope -- privileged users can enable seccomp w/o nnp.
Indeed, I am stupid.

Still it would be nice to cleanup this somehow. The new member is only
used as a previous ->no_new_privs, just it is long to allow the concurent
set/get. Logically it doesn't even belong to seccomp{}.

Oleg.
Thread (36 messages) 36 messages, 5 authors, last reply 2014-06-27
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help