Thread (47 messages) 47 messages, 5 authors, 2014-07-07

[PATCH v2 16/20] mfd: sun6i-prcm: Add support for Allwinner A23 PRCM

From: Chen-Yu Tsai <hidden>
Date: 2014-06-20 07:39:05
Also in: linux-devicetree, linux-serial, lkml

On Wed, Jun 18, 2014 at 8:24 PM, Maxime Ripard
[off-list ref] wrote:
On Wed, Jun 18, 2014 at 09:29:53AM +0100, Lee Jones wrote:
quoted
quoted
The Allwinner A23 SoC has a PRCM unit like the previous A31 SoC.
The differences are the AR100 clock can no longer be modified,
the APB0 clock has different divisors, and some clock gates are
gone.

This patch adds a compatible with a modified subdevice list for
the A23.

Signed-off-by: Chen-Yu Tsai <redacted>
---
 .../devicetree/bindings/mfd/sun6i-prcm.txt         |  2 +-
 drivers/mfd/sun6i-prcm.c                           | 30 ++++++++++++++++++++++
 2 files changed, 31 insertions(+), 1 deletion(-)
The patch looks fine to me, but I'm concerned about the size of the
patch set and the amount of subsystems it touches.

I am guessing that this patch can just be taken independently though.
Please correct me if I'm wrong.
I have a bit of the same concern. We have several comments on the
previous patches, so I'm not even sure this patch can go as is.

It would be much easier if you (ChenYu) could introduce first a very
basic with just the UART support, and then, as separate series,
clocks, PRCM, MMC, and so on.
OK. I will do that. I'll also try to send some of the independent
fixes separately.


ChenYu
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help