Thread (24 messages) flat view 24 messages, 2 authors, 2014-05-21

[PATCH 1/7] mfd: twl4030-power: Fix hang on reboot if sleep configuration was loaded earlier

From: Lee Jones <hidden>
Date: 2014-05-20 15:01:19
Also in: linux-devicetree, linux-omap

On Tue, 13 May 2014, Tony Lindgren wrote:
Looks like we can still hit the issue of wrong load order of
twl4030 configuration. If we have a sleep configuration loaded,
and do a warm reset, the device can hang while initializing the
wakeup12 sequence. We do have a warning message about wrong order
of twl4030 configuration, but in this case it does not help as
the sleep configuration was loaded during the previous boot and
the state of twl4030 is maintained throughout the warm reset.

Fix the issue by clearing any existing sleep configuration
before we load the warm reset configuration.

Cc: Peter Ujfalusi <redacted>
Signed-off-by: Tony Lindgren <tony@atomide.com>
---
 drivers/mfd/twl4030-power.c | 6 ++++++
 1 file changed, 6 insertions(+)
Can't vouch for the semantics of the patch, but the code looks good.

  Acked-by: Lee Jones [off-list ref]

Can I just apply this, or would you like Peter to review it first?

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org ? Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help