Thread (95 messages) 95 messages, 32 authors, 2014-06-25

[PATCH] bus/omap_l3: avoid sync initcall for modules

From: gregkh@linuxfoundation.org (Greg KH)
Date: 2014-05-14 17:39:33
Also in: lkml

On Tue, May 13, 2014 at 09:27:33AM -0700, Tony Lindgren wrote:
* Arnd Bergmann [off-list ref] [140513 08:13]:
quoted
On Monday 12 May 2014 15:20:07 Tony Lindgren wrote:
quoted
How about instead let's add this into include/linux/module.h
like we have for other initcalls:
I mean include/linux/init.h naturally..
 
quoted
quoted
#define postcore_initcall(fn)           module_init(fn)

There may be others missing too from there. BTW, this driver
might be few of the drivers that actually might need to be
initialized early for debugging to catch bad access from
other drivers.
There is a comment above those defines saying:

/* Don't use these in loadable modules, but some people do... */

so I'm not sure if adding more would be appreciated.

	Arnd
Well "some" in that comment is probably an understatement :)

$ git grep _initcall drivers/ | wc -l
737

I did not look what percentage has tristate in the Kconfig,
but that might keep some people from making loadable drivers.

Greg, is the following patch something you may want to
consider picking up?
Sure, is this needed to fix issues in 3.15-final, or is 3.16-rc1 ok?

thanks,

greg k-h
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help