[PATCH 2/2] iio:adc: at91 requires the input subsystem
From: Nicolas Ferre <hidden>
Date: 2014-05-09 10:01:53
Also in:
linux-iio, lkml
On 08/05/2014 16:56, Arnd Bergmann :
Building the at91 adc driver with CONFIG_INPUT disabled results in this build error: ERROR: "input_event" [drivers/iio/adc/at91_adc.ko] undefined! ERROR: "input_unregister_device" [drivers/iio/adc/at91_adc.ko] undefined! ERROR: "input_free_device" [drivers/iio/adc/at91_adc.ko] undefined! ERROR: "input_register_device" [drivers/iio/adc/at91_adc.ko] undefined! ERROR: "input_set_abs_params" [drivers/iio/adc/at91_adc.ko] undefined! ERROR: "input_allocate_device" [drivers/iio/adc/at91_adc.ko] undefined! To make sure we can build random configurations, this turns on CONFIG_INPUT whenever CONFIG_AT91_ADC is enabled.
Isn't it a "select" instead of "depends" that is required then?
quoted hunk ↗ jump to hunk
Signed-off-by: Arnd Bergmann <arnd@arndb.de> Cc: linux-iio at vger.kernel.org Cc: Josh Wu <redacted> Cc: Jonathan Cameron <jic23@kernel.org> Cc: Maxime Ripard <redacted> --- drivers/iio/adc/Kconfig | 1 + 1 file changed, 1 insertion(+)diff --git a/drivers/iio/adc/Kconfig b/drivers/iio/adc/Kconfig index 90f596d..a80d236 100644 --- a/drivers/iio/adc/Kconfig +++ b/drivers/iio/adc/Kconfig@@ -110,6 +110,7 @@ config AD799X config AT91_ADC tristate "Atmel AT91 ADC" depends on ARCH_AT91 + depends on INPUT select IIO_BUFFER select IIO_TRIGGERED_BUFFER select SYSFS
-- Nicolas Ferre