Thread (231 messages) 231 messages, 5 authors, 2014-05-08
STALE4453d

[PATCH 045/222] ARM: l2c: highbank: remove explicit SMI call in L2 cache initialisation

From: Russell King <hidden>
Date: 2014-04-25 11:34:46
Subsystem: arm port, arm/calxeda highbank architecture, the rest · Maintainers: Russell King, Andre Przywara, Linus Torvalds

Now that highbank uses the write_sec method, we don't need to enable
the L2 cache in SoC specific code; this can be done via the normal
mechanisms in the L2C code.

Checking with Rob Herring:
quoted
Can we kill the "highbank_smc1(0x102, 0x1);" here?	That means
l2x0_of_init() will see the L2 cache disabled, and will try to enable
it via the write_sec hook, so it should do the right thing.
Yes, that should work. You should be able to just call l2x0_of_init
unconditionally. The condition was really to just avoid the smc on
Midway which does get handled on h/w, but not if running virtualized.
So also drop the DT check too.  I'm leaving the config check in place
so that if L2 is disabled, the write_sec hook can be optimised away.

Signed-off-by: Russell King <redacted>
---
 arch/arm/mach-highbank/highbank.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/arch/arm/mach-highbank/highbank.c b/arch/arm/mach-highbank/highbank.c
index 4712aed3d9f6..245e588859ec 100644
--- a/arch/arm/mach-highbank/highbank.c
+++ b/arch/arm/mach-highbank/highbank.c
@@ -68,9 +68,7 @@ static void __init highbank_init_irq(void)
 		highbank_scu_map_io();
 
 	/* Enable PL310 L2 Cache controller */
-	if (IS_ENABLED(CONFIG_CACHE_L2X0) &&
-	    of_find_compatible_node(NULL, NULL, "arm,pl310-cache")) {
-		highbank_smc1(0x102, 0x1);
+	if (IS_ENABLED(CONFIG_CACHE_L2X0)) {
 		outer_cache.write_sec = highbank_l2c310_write_sec;
 		l2x0_of_init(0, ~0);
 	}
-- 
1.8.3.1
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help