Hi Sergei,

On: 21/03/2014 14:30, Sergei wrote:

Subject: Re: [PATCH v4 6/9] ARM: shmobile: Add PCIe device tree nodes 

for R8A7790

Hello.

On 03/21/2014 01:32 PM, Phil Edworthy wrote:

quoted

This patch adds the device tree nodes for R8A7790

quoted

Signed-off-by: Phil Edworthy <redacted>
---
  arch/arm/boot/dts/r8a7790.dtsi | 19 +++++++++++++++++++
  1 file changed, 19 insertions(+)

quoted

diff --git a/arch/arm/boot/dts/r8a7790.dtsi 

b/arch/arm/boot/dts/r8a7790.dtsi

quoted

index df9ec61..e7d498a 100644

--- a/arch/arm/boot/dts/r8a7790.dtsi
+++ b/arch/arm/boot/dts/r8a7790.dtsi

@@ -821,4 +821,23 @@
        #size-cells = <0>;
        status = "disabled";
     };
+
+   pcie: pcie at fe000000 {
+      compatible = "renesas,r8a7790-pcie";

    The convention adopted on this list is to put the "pcie" first, and 

SoC 

name the last.

Ok, shame that all the other PCI hosts use vendor,device-pcie

quoted

+      reg = <0 0xfe000000 0 0x80000>;
+      #address-cells = <3>;
+      #size-cells = <2>;
+      device_type = "pci";

    This legacy property is only meaningful for the true OF firmware and 

thus 

have been phased out (it's only actively used for the memory nodes).

Ok, thanks for pointing this out.

WBR, Sergei

Thanks
Phil