Thread (33 messages) 33 messages, 4 authors, 2014-03-27
STALE4471d

[PATCH V3 06/12] ARM: shmobile: r7s72100: add scif nodes to dtsi

From: laurent.pinchart@ideasonboard.com (Laurent Pinchart)
Date: 2014-03-07 16:37:36
Also in: linux-sh

Hi Wolfram,

On Friday 07 March 2014 17:25:10 Wolfram Sang wrote:
quoted
quoted
diff --git a/arch/arm/boot/dts/r7s72100.dtsi
b/arch/arm/boot/dts/r7s72100.dtsi index 6af5c28c670e..d49afe30c1d7
100644
--- a/arch/arm/boot/dts/r7s72100.dtsi
+++ b/arch/arm/boot/dts/r7s72100.dtsi
@@ -23,6 +23,14 @@
 		i2c1 = &i2c1;
 		i2c2 = &i2c2;
 		i2c3 = &i2c3;
+		serial0 = &scif0;
+		serial1 = &scif1;
+		serial2 = &scif2;
+		serial3 = &scif3;
+		serial4 = &scif4;
+		serial5 = &scif5;
+		serial6 = &scif6;
+		serial7 = &scif7;
As port usages is board specific, shouldn't this be moved to the board
.dts file, with only serial0 = &scif2 ?
Nope, the intention of these aliases is to have a consistent numbering
of SCIF cores, similar to platform.dev_id.
But do we want that ? Isn't it better from a user point of view to have ttySC0 
regardless of whether scif2 or scif3 is used when the board has a single 
serial port only ?

-- 
Regards,

Laurent Pinchart
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 490 bytes
Desc: This is a digitally signed message part.
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20140307/c8852421/attachment.sig>
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help