Thread (23 messages) 23 messages, 3 authors, 2014-03-08

[PATCH RFC v2 04/11] tty: xuartps: Remove bogus comment and register write

From: One Thousand Gnomes <hidden>
Date: 2014-03-07 21:29:13
Also in: linux-serial, lkml

On Fri,  7 Mar 2014 11:13:27 -0800
Soren Brinkmann [off-list ref] wrote:
quoted hunk ↗ jump to hunk
Signed-off-by: Soren Brinkmann <redacted>
---
 drivers/tty/serial/xilinx_uartps.c | 6 +-----
 1 file changed, 1 insertion(+), 5 deletions(-)
diff --git a/drivers/tty/serial/xilinx_uartps.c b/drivers/tty/serial/xilinx_uartps.c
index a4bd6242e72d..a39c2d290902 100644
--- a/drivers/tty/serial/xilinx_uartps.c
+++ b/drivers/tty/serial/xilinx_uartps.c
@@ -1082,11 +1082,7 @@ static void xuartps_console_write(struct console *co, const char *s,
 
 	xuartps_writel(ctrl, XUARTPS_CR_OFFSET);
 
-	/* restore interrupt state, it seems like there may be a h/w bug
-	 * in that the interrupt enable register should not need to be
-	 * written based on the data sheet
-	 */
-	xuartps_writel(~imr, XUARTPS_IDR_OFFSET);
+	/* restore interrupt state */
It would be appropriate for the changelog at least to explain why the
note about the data sheet differing is going away !
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help