[PATCH v4 03/13] ARM: mvebu: ll_set_cpu_coherent always uses the current CPU
From: Thomas Petazzoni <hidden>
Date: 2014-02-19 16:09:07
Also in:
linux-pm
Dear Gregory CLEMENT, On Thu, 13 Feb 2014 18:33:26 +0100, Gregory CLEMENT wrote:
ll_set_cpu_coherent is always used on the current CPU, so instead of passing the CPU id as argument, ll_set_cpu_coherent() can find it by itself. Signed-off-by: Gregory CLEMENT <redacted> --- arch/arm/mach-mvebu/coherency.c | 10 +++++----- arch/arm/mach-mvebu/coherency.h | 2 +- arch/arm/mach-mvebu/coherency_ll.S | 12 ++++++------ arch/arm/mach-mvebu/headsmp.S | 4 ---- arch/arm/mach-mvebu/platsmp.c | 2 +- 5 files changed, 13 insertions(+), 17 deletions(-)
Acked-by: Thomas Petazzoni <redacted> with just one thing I am not entirely sure about:
/* Create bit by cpu index */ - mov r3, #(1 << 24) - lsl r1, r3, r1 -ARM_BE8(rev r1, r1) + mrc 15, 0, r1, cr0, cr0, 5 + and r1, r1, #15 + mov r2, #(1 << 24) + lsl r1, r2, r1 + ARM_BE8(rev r1, r1)
Have you tested this in a big endian configuration? I'd like to make sure we have gotten the ARM_BE8(rev ...) thing correct. Thomas -- Thomas Petazzoni, CTO, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com