Thread (36 messages) flat view 36 messages, 8 authors, 2014-02-19

[PATCH 0/4] clk: mvebu: fix clk init order

From: emilio@elopez.com.ar (Emilio López)
Date: 2014-02-17 14:42:50
Also in: lkml

Hi Gregory, Ezequiel,

 >> Are we still in time to consider Emilio's oneline proposal?
quoted
(Emilio: would you mind preparing a suitable patch against dove,
kirkwood, armada370/xp, so we can see the real thing?).
The patch is in a common file, so it does not need patching anything for 
each platform.
I am still strongly against this proposal because hard-coded the parent
clock name in the driver seems very wrong
It is hardcoded already when the parent is registered, so I do not 
understand your concern.

http://lxr.free-electrons.com/source/drivers/clk/mvebu/common.c?v=3.13#L34
and moreover in some circumstances
(if there is no output-name, which is our default case) this proposal
just ignored the parent clock given by the device tree and this looked
more wrong.
I have sent a second patch addressing this comment, but you do not seem 
to have taken too serious a look at it.

http://www.spinics.net/lists/arm-kernel/msg305922.html

Cheers,

Emilio
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help