Thread (26 messages) read the whole thread 26 messages, 5 authors, 2014-02-03

NFS client broken in Linus' tip

From: Trond Myklebust <hidden>
Date: 2014-02-03 14:17:35
Also in: linux-nfs, lkml

On Feb 3, 2014, at 3:03, Christoph Hellwig [off-list ref] wrote:
On Fri, Jan 31, 2014 at 03:59:30PM -0500, Trond Myklebust wrote:
quoted
posix_acl_xattr_get requires get_acl() to return EOPNOTSUPP if the
filesystem cannot support acls. This is needed for NFS, which can't
know whether or not the server supports acls until it tries to get/set
one.
This patch converts posix_acl_chmod and posix_acl_create to deal with
EOPNOTSUPP return values from get_acl().
Shouldn't NFS just return a NULL ACL here?
As I said above, that causes posix_acl_xattr_get() to return the wrong answer (ENODATA instead of EOPNOTSUPP).

--
Trond Myklebust
Linux NFS client maintainer
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help