Felipe,

 >

On 01/14/2014 08:04 AM, Felipe Balbi wrote:

quoted

Hi again,

On Tue, Jan 14, 2014 at 07:10:52AM -0600, Felipe Balbi wrote:

quoted

quoted

diff --git a/drivers/hwspinlock/omap_hwspinlock.c

b/drivers/hwspinlock/omap_hwspinlock.c
index 9f56fb2..194886e 100644

--- a/drivers/hwspinlock/omap_hwspinlock.c
+++ b/drivers/hwspinlock/omap_hwspinlock.c

@@ -101,10 +101,23 @@ static int omap_hwspinlock_probe(struct

platform_device *pdev)
      if (!io_base)
          return -ENOMEM;

+    /*
+     * make sure the module is enabled and clocked before reading
+     * the module SYSSTATUS register
+     */
+    pm_runtime_enable(&pdev->dev);
+    pm_runtime_get_sync(&pdev->dev);

another thing, you need to check return of pm_runtime_get_sync()

OK, let me check this and your other comment, and the fix is probably a
separate patch.

I realized the changes relevant to your comments were introduced in this 
patch, so just refreshed the patch with fixes instead of doing a 
separate patch. I didn't do a v5 just for these change, and will do so 
if there are more comments on the DT adaptation.

regards
Suman