[PATCHv4 6/7] hwspinlock/omap: enable module before reading SYSSTATUS register
From: Anna, Suman <hidden>
Date: 2014-01-14 16:57:14
Also in:
linux-devicetree, linux-omap, lkml
From: Anna, Suman <hidden>
Date: 2014-01-14 16:57:14
Also in:
linux-devicetree, linux-omap, lkml
Felipe, On 01/14/2014 08:04 AM, Felipe Balbi wrote:
Hi again, On Tue, Jan 14, 2014 at 07:10:52AM -0600, Felipe Balbi wrote:quoted
quoted
diff --git a/drivers/hwspinlock/omap_hwspinlock.c b/drivers/hwspinlock/omap_hwspinlock.c index 9f56fb2..194886e 100644 --- a/drivers/hwspinlock/omap_hwspinlock.c +++ b/drivers/hwspinlock/omap_hwspinlock.c@@ -101,10 +101,23 @@ static int omap_hwspinlock_probe(struct platform_device *pdev) if (!io_base) return -ENOMEM; + /* + * make sure the module is enabled and clocked before reading + * the module SYSSTATUS register + */ + pm_runtime_enable(&pdev->dev); + pm_runtime_get_sync(&pdev->dev);another thing, you need to check return of pm_runtime_get_sync()
OK, let me check this and your other comment, and the fix is probably a separate patch. regards Suman