Hi Pavel,

On 12.01.2014 12:47, Pavel Machek wrote:

On Sat 2014-01-11 20:42:43, Tomasz Figa wrote:

quoted

This patch removes name field from private s3c64xx_pm_domain struct and
moves domain name to dedicated field of generic_pm_domain struct.

When at it, beautify the names a bit, since they are used by genpd core
as message prefixes.

Signed-off-by: Tomasz Figa <redacted>
---
  arch/arm/mach-s3c64xx/pm.c | 19 +++++++++----------
  1 file changed, 9 insertions(+), 10 deletions(-)

diff --git a/arch/arm/mach-s3c64xx/pm.c b/arch/arm/mach-s3c64xx/pm.c
index 8cdb824..5238d66 100644
--- a/arch/arm/mach-s3c64xx/pm.c
+++ b/arch/arm/mach-s3c64xx/pm.c

@@ -35,7 +35,6 @@
  #include "regs-syscon-power.h"

  struct s3c64xx_pm_domain {
-	char *const name;
  	u32 ena;
  	u32 pwr_stat;
  	struct generic_pm_domain pd;

@@ -76,7 +75,7 @@ static int s3c64xx_pd_on(struct generic_pm_domain *domain)
  		} while (retry--);

  		if (!retry) {
-			pr_err("Failed to start domain %s\n", pd->name);
+			pr_err("Failed to start domain %s\n", pd->pd.name);
  			return -EBUSY;
  		}

So you changed text "failed to start domain I" to "failed to start
domain domain_i". Not sure that's an improvement...?

Right. I apparently missed this, since this error should never happen 
unless there is something wrong with your hardware (SoC or PMIC).

Still, the generic code in drivers/base/power/domain.c does not add the 
"domain" prefix to the message. Without this patch it was printing 
messages like

I: Power-on latency exceeded, new value 1000 ns

I'd say that what's need adjustment are the messages in 
mach-s3c64xx/pm.c to print "%s: Failed to start\n" and keep things 
consistent with higher level code.

Could we get some more descriptive names for the domains?

They are listed like this in user's manual, e.g. DOMAIN_F, DOMAIN_I, 
DOMAIN_G, etc.

Best regards,
Tomasz