Thread (15 messages) 15 messages, 3 authors, 2014-01-06

[PATCH V2 2/5] arm: shmobile: r7s72100: add i2c clocks

flat view

From: Geert Uytterhoeven <geert@linux-m68k.org>
Date: 2013-12-26 21:51:34
Also in: linux-i2c, linux-sh

On Thu, Dec 26, 2013 at 10:34 PM, Geert Uytterhoeven
[off-list ref] wrote:
quoted
quoted
Note that after dropping these lines:

       CLKDEV_DEV_ID("fcfee000.i2c", &mstp_clks[MSTP97]),
       CLKDEV_DEV_ID("fcfee400.i2c", &mstp_clks[MSTP96]),
       CLKDEV_DEV_ID("fcfee800.i2c", &mstp_clks[MSTP95]),
       CLKDEV_DEV_ID("fcfeec00.i2c", &mstp_clks[MSTP94]),

i2c stopped working.
??? Why do you want to drop these lines?
Your v2 dropped them, presumably in response to Sergei's ICKy comments.
And that's what Simon committed...
Upon checking again, your v2 did contain them, but gmail tried to smart
me out by not showing those few lines.
So it must have been Simon who dropped them, or lost them during rebase?

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert at linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help