[PATCH v4 2/4] mvebu: Dove: Instantiate cpufreq driver.
From: andrew@lunn.ch (Andrew Lunn)
Date: 2013-12-05 18:29:39
Also in:
linux-pm
I'm not arguing for describing a pseudo-device. The power management unit is a real device. If we used that to register a cpufreq driver, it doesn't mean that we've registered a pseudo-device, but rather that we made a decision to register the cpufreq portions based on the necessary real devices being present.
Hi Mark I need a more concrete explanation to understand what you mean. Are you suggesting that i add a drivers/pmu/dove.c, which gets instantiated by DT? This driver would then instantiate the cpufreq driver? If so, it should also instantiate the gated clocks in drivers/clk/mvebu/dove.c, since they are also part of the PMU, according to the data sheet. The RTC and the thermal management unit are also part of the PMU. Should these drivers also be instantiated by the PMU somehow?
Perhaps this was the problem with the proposed kirkwood binding?
Kirkwood does not have a PMU, at least not according to the data
sheet. There are registers to control cpuidle, cpufreq, gating some
clocks, the exact same RTC and a somewhat similar thermal
sensor. However the data sheet makes no reference as to calling the
collection the "PMU".
Thanks
Andrew