On Wed, Dec 4, 2013 at 4:38 PM, Hanjun Guo [off-list ref] wrote:

On 2013?12?04? 01:25, Rob Herring wrote:

quoted

On Tue, Dec 3, 2013 at 10:39 AM, Hanjun Guo [off-list ref] wrote:

quoted

From: Amit Daniel Kachhap <redacted>

This patch introduces a new API for acpi based irq mapping.

[hanjun: Rework this patch to delete the reference to
gic_irq_domain_xlate() which can simplify the code a lot.]

Signed-off-by: Amit Daniel Kachhap <redacted>
Signed-off-by: Hanjun Guo <redacted>

(...)

quoted

quoted

+EXPORT_SYMBOL_GPL(irq_create_acpi_mapping);

There is nothing ACPI specific about this function. This is simply
irq_create_of_mapping w/o translating of_phandle_args to a hwirq and
type. So I expect the code to be re-factored here to mirror that.

Sorry for my bad english, do you mean create a OF free function
and call that from the OF function ?

Sounds like a good idea, like if you move the OF function into
kernel/irq/irqdomain.c and get rid of the OF specific naming
then use that same function from ACPI too. It's all about
using the irq_default_domain in a standard way after all right?

Yours,
Linus Walleij