On 2013-12-6 7:09, Arnd Bergmann wrote:

On Wednesday 04 December 2013, Rob Herring wrote:

quoted

quoted

index a0c2ca6..1428024 100644

--- a/arch/arm64/kernel/smp.c
+++ b/arch/arm64/kernel/smp.c

@@ -420,7 +420,9 @@ void __init smp_prepare_cpus(unsigned int max_cpus)
                if (err)
                        continue;

+#ifndef CONFIG_ACPI
                set_cpu_present(cpu, true);
+#endif

Should this be moved to DT cpu topology related code?

More importantly, the #ifndef is certainly wrong here: It is important that you can
turn CONFIG_ACPI on or off without impacting the run-time code path for non-ACPI
systems. The snippet above breaks this because we no longer set the
cpu mask when ACPI is turned on but not used.

Good point, I'll rework this patch to find a better solution.

Thanks for your comments.

Hanjun