Thread (46 messages) 46 messages, 11 authors, 2013-11-06
STALE4637d

[PATCH 00/19] Enable various Renesas drivers on all ARM platforms

From: Tomi Valkeinen <hidden>
Date: 2013-10-30 10:59:08
Also in: linux-i2c, linux-input, linux-iommu, linux-mmc, linux-pm, linux-pwm, linux-serial, linux-spi, netdev

On 2013-10-30 02:05, Simon Horman wrote:
On Tue, Oct 29, 2013 at 10:58:34AM -0700, Mark Brown wrote:
quoted
On Tue, Oct 29, 2013 at 06:29:59PM +0100, Laurent Pinchart wrote:
quoted
On Tuesday 29 October 2013 10:23:31 Mark Brown wrote:
quoted
On Tue, Oct 29, 2013 at 06:05:53PM +0100, Laurent Pinchart wrote:
quoted
The first one is that I can't compile-test all those drivers on all
architectures. The spi-sh-msiof driver, for instance, uses
io(read|write)(16|
quoted
quoted
Which architectures are these and is there not a symbol we can depend on
for them?
quoted
arch/cris for instance. We can use readl/writel instead (maybe it would be 
time to rationalize and document the I/O accessors across all architectures, 
but that's another topic).
It'd certainly be sensible, or adding a config option to depend on if
you rely on these functions.
quoted
My point is that there might be other issues that I won't be able to easily 
catch. This would break compilation for everybody for no reason, as the 
drivers are useless on non-SuperH, non-ARM platforms. That's why I believe 
COMPILE_TEST would be a better option as a first step.
Yes, it would - please do that.  Note that it won't stop anyone running
into build issues on other architectures though, it's just about
stopping Kconfig noise.
FWIW, I am happy with using COMPILE_TEST for this series.
I'd also go for COMPILE_TEST. I once enabled omapdss and omapfb to be
compilable without any extra dependencies, and Linus wasn't fond of
getting asked if he wants to compile omapfb or not...

 Tomi


-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 901 bytes
Desc: OpenPGP digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20131030/b75b2a9a/attachment.sig>
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help