On Wed, Oct 23, 2013 at 08:30:02PM +0530, Viresh Kumar wrote:

On 23 October 2013 20:06, Andrew Lunn [off-list ref] wrote:

quoted

quoted

So, you have actually tested your code without interrupt handler?

No.

It would be better if you atleast try this and confirm that this dummy
handler is required.

quoted

quoted

What exactly happens in that case?

Take a look at request_threaded_irq(). It contains:

1421         if (!handler) {
1422                 if (!thread_fn)
1423                         return -EINVAL;

So devm_request_irq() will fail, and so the probe function will fail.

Obviously I wanted you to remove all irq specific code and hence
devm_request_irq() :)

So you want to know if WFI exits without an interrupt being delivered?
The Marvell documentation says the interrupt should be enabled, but we
can try it with it disabled.

    Andrew