Thread (40 messages) 40 messages, 7 authors, 2013-10-14

[PATCH 2/2] PCI: imx6: Fix the clock for PCIe

flat view
STALE4744d

From: marex@denx.de (Marek Vasut)
Date: 2013-10-11 11:55:04
Also in: linux-pci

Revision v7 of 3 in this series.

Revisions (3)
  1. v7
  2. v7
  3. v7 current
Dear Jingoo Han,
On Friday, October 11, 2013 11:13 AM, Marek Vasut wrote:
quoted
The clk #205 are lvds_sel, not lvds_gate , so fix this. Moreover,
the PCIe needs lvds_gate for successful operation, so make the PCIe
driver enable (set as output) the lvds_gate .

Signed-off-by: Marek Vasut <marex@denx.de>
Cc: Bjorn Helgaas <bhelgaas@google.com>
Cc: Frank Li <redacted>
Cc: Richard Zhu <redacted>
Cc: Sascha Hauer <s.hauer@pengutronix.de>
Cc: Sean Cross <redacted>
Cc: Shawn Guo <redacted>
Cc: Tim Harvey <tharvey@gateworks.com>
Cc: Yinghai Lu <yinghai@kernel.org>
---

 arch/arm/boot/dts/imx6qdl.dtsi |  6 +++---
 drivers/pci/host/pci-imx6.c    | 19 ++++++++++++++++++-
 2 files changed, 21 insertions(+), 4 deletions(-)
Hi Marek Vasut,

How about splitting this patch into two patches such as
arch part and driver part?

It is because driver part was merged into PCI tree by Bjorn Helgaas,[1]
and arch part was merged into i.MX tree by Shawn Guo.[2]
Thus, your patch can make the conflict issue.

For example,
  [PATCH 1/2] ARM: dts: imx6qdl: Fix the clock for PCIe
  [PATCH 2/2] PCI: imx6: Fix the clock for PCIe

Then, 1st patch can be merged to i.MX tree, and 2nd patch can be merged
to PCI tree.

If I am wrong, please let me know kindly. :-)
By all means, you're right. Is the patch addressing the issue correctly (if we 
ignore that it's not split)? Shawn?

Best regards,
Marek Vasut
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help