Thread (37 messages) 37 messages, 6 authors, 2013-10-08

[PATCH 3/4] clk: kirkwood: Add CLK_IGNORE_UNUSED to ethernet ge0 and ge1 clocks

STALE4745d

From: andrew@lunn.ch (Andrew Lunn)
Date: 2013-09-30 21:34:37

Hi Jason
Our bootloader gates the power and turns off the clock, having Linux
turn the clock back on without knowing how to control the power seems
like a possible problem.
This patch won't do that. This patch will stop it getting turn off. It
will never turn it on. The only thing that will turn it on is the
Ethernet driver. So if the bootloader turned it off, it should stay
off.
I don't have code, but when this was first brought up it was suggested
to add local-mac-address to the DT nodes if it isn't present in the
common code and don't mess with the clocks.

Psudeo code:

void marvell_dt_ethernet_fixup(void)
{
 for_each_compatible_node(np, "marvell,kirkwood-eth-port")
 {
   if (of_get_mac_address(np) != NULL)
      continue;
   regs = ioremap(of_regs(np->parent,0));
   address = (readl(regs + MAC_ADDR_HIGH) << 32) | 
              readl(regs + MAC_ADDR_LOW))
   iounmap(regs);
   of_add_property(np, {"local-mac-address" = address});
 }
}
The pseudo code looks nice, but i think in reality, the
of_add_property(np, {"local-mac-address" = address}); is not so
simple. Sebastian took a look at this.

	Andrew
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help