Thread (37 messages) 37 messages, 6 authors, 2013-10-08

[PATCH 3/4] clk: kirkwood: Add CLK_IGNORE_UNUSED to ethernet ge0 and ge1 clocks

flat view
STALE4746d

From: Ezequiel Garcia <hidden>
Date: 2013-09-30 21:03:29
Subsystem: arm/marvell kirkwood and armada 370, 375, 38x, 39x, xp, 3700, 7k/8k, cn9130 soc support, common clk framework, the rest · Maintainers: Andrew Lunn, Gregory Clement, Sebastian Hesselbarth, Stephen Boyd, Brian Masney, Jerome Brunet, Linus Torvalds

These clocks should never be gated, since the ethernet interfaces forget
the assigned MAC address assigned if their clock source is turned off.

Signed-off-by: Ezequiel Garcia <redacted>
---
Cc: Mike Turquette <redacted>

 drivers/clk/mvebu/kirkwood.c | 9 +++++++--
 1 file changed, 7 insertions(+), 2 deletions(-)
diff --git a/drivers/clk/mvebu/kirkwood.c b/drivers/clk/mvebu/kirkwood.c
index 2636a55..69d9603 100644
--- a/drivers/clk/mvebu/kirkwood.c
+++ b/drivers/clk/mvebu/kirkwood.c
@@ -220,7 +220,12 @@ CLK_OF_DECLARE(mv88f6180_core_clk, "marvell,mv88f6180-core-clock",
  */
 
 static const struct clk_gating_soc_desc kirkwood_gating_desc[] __initconst = {
-	{ "ge0", NULL, 0, 0 },
+	/*
+	 * The ethernet interfaces forget their assigned MAC address
+	 * if the clocks are turned off. Until proper DT support
+	 * is available we prevent ge0 and ge1 gating for now.
+	 */
+	{ "ge0", NULL, 0, CLK_IGNORE_UNUSED },
 	{ "pex0", NULL, 2, 0 },
 	{ "usb0", NULL, 3, 0 },
 	{ "sdio", NULL, 4, 0 },
@@ -234,7 +239,7 @@ static const struct clk_gating_soc_desc kirkwood_gating_desc[] __initconst = {
 	{ "xor1", NULL, 16, 0 },
 	{ "crypto", NULL, 17, 0 },
 	{ "pex1", NULL, 18, 0 },
-	{ "ge1", NULL, 19, 0 },
+	{ "ge1", NULL, 19, CLK_IGNORE_UNUSED },
 	{ "tdm", NULL, 20, 0 },
 	{ }
 };
-- 
1.8.1.5
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help